Skip to content

Fixes for wheels#64

Merged
desilinguist merged 2 commits intopygridtools:masterfrom
jakirkham:fix_setup_cfg
Mar 26, 2018
Merged

Fixes for wheels#64
desilinguist merged 2 commits intopygridtools:masterfrom
jakirkham:fix_setup_cfg

Conversation

@jakirkham
Copy link
Copy Markdown
Contributor

  • Wheel section should be bdist_wheel (details in commit)
  • Package the license file in the wheel

Was named `wheel` previously, but should be named `bdist_wheel` as that
is the subcommand that this argument is being passed to.

ref: https://wheel.readthedocs.io/en/stable/#defining-the-python-version
Makes sure the license file gets included in the wheel so that is
available for the end user to inspect in the installed environment.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.969% when pulling 6dc567f on jakirkham:fix_setup_cfg into 50d1757 on pygridtools:master.

3 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.969% when pulling 6dc567f on jakirkham:fix_setup_cfg into 50d1757 on pygridtools:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 18, 2018

Coverage Status

Coverage remained the same at 90.969% when pulling 6dc567f on jakirkham:fix_setup_cfg into 50d1757 on pygridtools:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.969% when pulling 6dc567f on jakirkham:fix_setup_cfg into 50d1757 on pygridtools:master.

@jakirkham
Copy link
Copy Markdown
Contributor Author

Thoughts @desilinguist?

@desilinguist
Copy link
Copy Markdown
Contributor

LGTM 👍

@desilinguist desilinguist merged commit 61b5eb6 into pygridtools:master Mar 26, 2018
@jakirkham jakirkham deleted the fix_setup_cfg branch March 26, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants