gh-107211: Fix select extension build on Solaris#108012
Conversation
30ce6fd to
87a1a21
Compare
|
@kulikjak: Can you please check if this change fix your build issue? ref: #107211 (comment) |
Export the internal _Py_open() and _Py_write() functions for Solaris: the select shared extension uses them.
87a1a21 to
dbc8633
Compare
kulikjak
left a comment
There was a problem hiding this comment.
Thank you very much! I tested it and the issues are gone.
|
You're welcome. It seems like we have no Solaris buildbot anymore. I'm fine with you reporting issues manually :-) |
|
Thank you. As for the buildbot worker, there is technically a Solaris one I am maintaining, but sadly it's red all the time as there are some Solaris-specific changes that would need to be merged first. I created PRs for most of them some time ago, but they were not merged yet, and ATM they will probably need some rebasing and possibly minor updates to make them mergeable again. Our internal buildbot is green/yellow most of the time, so it's definitely possible. I will look into it again. |
Export the internal _Py_open() function for Solaris: the select extension uses it in its newDevPollObject() function.