gh-126835: Fold unary & binary complex constant expressions during code generation.#129963
Closed
WolframAlph wants to merge 7 commits intopython:mainfrom
Closed
gh-126835: Fold unary & binary complex constant expressions during code generation.#129963WolframAlph wants to merge 7 commits intopython:mainfrom
WolframAlph wants to merge 7 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codegen expects unary & binary complex constant expressions already folded. Without it, we cannot proceed with migration of unaryop & binaryop to CFG. cc @Eclips4 @tomasr8
This PR does 2 things:
This PR is created in case we decide to go with this approach.