GH-130396: Work around for broken pthread_get_stackaddr_np on Emscripten#131088
Merged
freakboy3742 merged 3 commits intopython:mainfrom Mar 13, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten reports having
pthread_get_stackaddr_npbut it does nothing. I opened an upstream PR to actually fill in the stack information: emscripten-core/emscripten#23887Until we can update to an Emscripten version that includes this fix, we can work around it by using
#defines to replacepthread_get_stackaddr_npwith the modified version.