gh-146261: Fix bug in _Py_uop_sym_set_func_version#146291
Merged
Fidget-Spinner merged 2 commits intopython:mainfrom Mar 22, 2026
Merged
gh-146261: Fix bug in _Py_uop_sym_set_func_version#146291Fidget-Spinner merged 2 commits intopython:mainfrom
_Py_uop_sym_set_func_version#146291Fidget-Spinner merged 2 commits intopython:mainfrom
Conversation
| case JIT_SYM_TRUTHINESS_TAG: | ||
| sym_set_bottom(ctx, sym); | ||
| return true; | ||
| return false; |
Member
There was a problem hiding this comment.
Sorry, can you just reduce the PR to just this line? I'm really sorry for taking up your time on this Sacul.
After staring at this more, I realised the original function watcher idea works, but needs a lot more work. I think this might be too complicated for a contributor to take, so I'll take over. Thanks for opening the issue again and for spotting this mistake of mine!
Contributor
Author
There was a problem hiding this comment.
No worries, glad to be able to help where I can :)
_CHECK_FUNCTION_VERSION in the JIT_Py_uop_sym_set_func_version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
_Py_uop_sym_set_func_versionwhere it should returnfalseinstead oftruewhen we hit the bottom._CHECK_FUNCTION_VERSIONis wrong #146261