gh-146236: datetime: Improve comparing datetime objects#146294
Closed
jepler wants to merge 1 commit intopython:mainfrom
Closed
gh-146236: datetime: Improve comparing datetime objects#146294jepler wants to merge 1 commit intopython:mainfrom
jepler wants to merge 1 commit intopython:mainfrom
Conversation
Comparing datetime objects with different `fold=` attributes did not preserve the documented "precedes/follows" semantics of comparisons.
Contributor
Author
|
I'll investigate the build failures. They seem to indicate I made an error in refcounting. |
Contributor
Author
|
Aside from the refcounting bug, I now understand that the approach of conversion to timestamp will not work, because e.g., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing datetime objects with different
fold=attributes did not preserve the documented "precedes/follows" semantics of comparisons.Closes: #146236
folded time #146236📚 Documentation preview 📚: https://cpython-previews--146294.org.readthedocs.build/