gh-145633: Fix struct.pack('f') on s390x#146422
gh-145633: Fix struct.pack('f') on s390x#146422vstinner wants to merge 2 commits intopython:mainfrom
Conversation
Use PyFloat_Pack4() to raise OverflowError. Add more tests on packing/unpacking floats.
|
@skirpichev: Would you mind to review this change? |
skirpichev
left a comment
There was a problem hiding this comment.
(Sorry, I forgot to submit review yesterday.)
Looks ok, but maybe we should rather keep test_705836(), just with a small addition in the end.
Co-authored-by: Sergey B Kirpichev <[email protected]>
|
!buildbot s390x Fedora Stable |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit ce1093b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146422%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot SPARCv9 Oracle Solaris 11.4 PR |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit ce1093b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146422%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Use PyFloat_Pack4() to raise OverflowError.
Add more tests on packing/unpacking floats.