gh-148171: Convert variadic argument opcodes to leave their arguments on the stack (CALL_BUILTIN_FAST_WITH_KEYWORDS)#148366
Merged
Fidget-Spinner merged 4 commits intopython:mainfrom Apr 11, 2026
Conversation
Open
5 tasks
Fidget-Spinner
approved these changes
Apr 11, 2026
Member
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Just one quip with the test. Please fix and I will merge. Thanks!
Lib/test/test_capi/test_opt.py
Outdated
| self.assertIn("_CALL_BUILTIN_FAST_WITH_KEYWORDS", uops) | ||
| self.assertNotIn("_GUARD_CALLABLE_BUILTIN_FAST_WITH_KEYWORDS", uops) | ||
| self.assertGreaterEqual(count_ops(ex, "_POP_TOP_NOP"), 5) | ||
| self.assertGreaterEqual(count_ops(ex, "_POP_TOP"), 3) |
Member
There was a problem hiding this comment.
Please remove this, we probably will have more in the future when we optimize more ops.
Contributor
Author
There was a problem hiding this comment.
Oh alr, gimme a sec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.