Skip to content

bpo-36329: Remove 'make -C Doc serve' in favour of 'make -C Doc htmlview'#32354

Merged
encukou merged 5 commits intopython:mainfrom
hugovk:36329-docs-make-htmlview
Apr 29, 2022
Merged

bpo-36329: Remove 'make -C Doc serve' in favour of 'make -C Doc htmlview'#32354
encukou merged 5 commits intopython:mainfrom
hugovk:36329-docs-make-htmlview

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Apr 6, 2022 •
edited
Loading

Matching Devguide PR: python/devguide#826.

Also updated make -C htmlview so it used a full path with file://, because the original didn't open the page (macOS).

For example:

cd Doc

# Doesn't open anything:
python3 -c "import webbrowser; webbrowser.open('build/html/index.html')"

# Opens the docs page e.g. file:///Users/hugo/github/cpython/Doc/build/html/index.html :
python3 -c "import os, webbrowser; webbrowser.open('file://' + os.path.realpath('build/html/index.html'))"

https://bugs.python.org/issue36329

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk @encukou @the-knights-who-say-ni @bedevere-bot