This repository was archived by the owner on Jul 5, 2023. It is now read-only.
FIX: build on cpython master branch#128
Merged
gvanrossum merged 1 commit intopython:masterfrom Nov 11, 2019
Merged
Conversation
python/cpython#16013 python/cpython@3a4f667 removed two arguments from _PyBytes_DecodeEscape . This calls _PyBytes_DecodeEscape with the new signature if the minor version is 9 or greater.
gvanrossum
approved these changes
Nov 11, 2019
Member
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM. Thanks for catching this!
Member
|
I guess it's too early in the CPython release cycle to do a new typed_ast release just to make it compile with 3.9. Let's just remember this here PR if we get bug reports about not typed_ast compiling for 3.9. |
|
is this fixed? because I am still facing this issue when trying to build the wheel for |
|
For posterity, this was fixed in 1.4.1. If you are building an older version things will break with Python 3.9. |
|
Yeah thank you, this is fixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python/cpython#16013 / python/cpython@3a4f667
removed two arguments from _PyBytes_DecodeEscape .
This calls _PyBytes_DecodeEscape with the new signature if the minor version is 9 or greater.
Followed the convention of only checking minor versions from earlier in the code.