Fix bandwidth function for DT systems#1212
Open
aWZHY0yQH81uOYvH wants to merge 1 commit intopython-control:mainfrom
Open
Fix bandwidth function for DT systems#1212aWZHY0yQH81uOYvH wants to merge 1 commit intopython-control:mainfrom
aWZHY0yQH81uOYvH wants to merge 1 commit intopython-control:mainfrom
Conversation
Contributor
|
Thanks for the submission. Looks like this was a bug, and your submission appears to correctly avoid problems that could arise in the optimization routine because the frequency response of discrete-time systems is periodic. Can you add a unit test? I think that all that would be needed would be a confirmation of correct behavior on a first-order system. |
Contributor
|
I think the failing unit tests are unrelated. Sometimes they go away on a re-run |
Author
|
Ok, unit test added. |
1ccbbfd to
5c37bdf
Compare
Contributor
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frequency needs to be evaluated differently for discrete-time systems.