Update dependency to support suds-community#159
Merged
radzhome merged 3 commits intopython-fedex-devs:masterfrom Jan 27, 2022
Merged
Update dependency to support suds-community#159radzhome merged 3 commits intopython-fedex-devs:masterfrom
radzhome merged 3 commits intopython-fedex-devs:masterfrom
Conversation
…on in setuptools v58.0.0
|
Any reasons why this is not merged? |
This was referenced Nov 30, 2021
Closed
|
When will this change get released? |
|
@radzhome Any chance we can get this change approved please? Thanks |
|
Since #160 has been merged, this should also be closed, shouldn't it? It's now a duplicate. |
|
#160 was closed, not merged. Master branch is still using |
|
Thank you! When will the next version with this change in it get released? |
|
Any update on the release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve issue #158
While building with the latest version of fedex our ci/cd process breaks while attempting to install the dependency
suds-jurko.Upon further examination it turns out that python's setuptools drops support for 2to3 in version v.58.0.0. In order to correct this it is recommended to switch to the new and actively maintained package suds-community which already has resolved this problem HERE.
Closes #158
I have also opted to pin this dependency for future cases where the project can be more intentional with the versions expected.