-
Notifications
You must be signed in to change notification settings - Fork 677
test: adapt functional tests for GitLab 15.8 #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cd30232
test: don't use weak passwords
JohnVillalovos 7d6f260
test: don't expect an empty list of custom attributes
JohnVillalovos 93b5da0
test: use GITLAB_TAG=15.8.1-ee.0
JohnVillalovos 97e8044
test(functional): enable bulk import feature flag before test
nejch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,15 +10,15 @@ def test_groups(gl): | |
| "email": "[email protected]", | ||
| "username": "user", | ||
| "name": "user", | ||
| "password": "user_pass", | ||
| "password": "E4596f8be406Bc3a14a4ccdb1df80587#!1", | ||
| } | ||
| ) | ||
| user2 = gl.users.create( | ||
| { | ||
| "email": "[email protected]", | ||
| "username": "user2", | ||
| "name": "user2", | ||
| "password": "user2_pass", | ||
| "password": "E4596f8be406Bc3a14a4ccdb1df80587#!#2", | ||
| } | ||
| ) | ||
| group1 = gl.groups.create( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ def test_create_user(gl, fixture_dir): | |
| "email": "[email protected]", | ||
| "username": "foo", | ||
| "name": "foo", | ||
| "password": "foo_password", | ||
| "password": "E4596f8be406Bc3a14a4ccdb1df80587#!", | ||
| "avatar": open(fixture_dir / "avatar.png", "rb"), | ||
| } | ||
| ) | ||
|
|
@@ -65,7 +65,7 @@ def test_delete_user(gl, wait_for_sidekiq): | |
| "email": "[email protected]", | ||
| "username": "delete-user", | ||
| "name": "delete-user", | ||
| "password": "delete-user-pass", | ||
| "password": "E4596f8be406Bc3a14a4ccdb1df80587#!", | ||
| } | ||
| ) | ||
|
|
||
|
|
@@ -100,7 +100,7 @@ def test_list_multiple_users(gl, user): | |
| "email": second_email, | ||
| "username": second_username, | ||
| "name": "Foo Bar", | ||
| "password": "foobar_password", | ||
| "password": "E4596f8be406Bc3a14a4ccdb1df80587#!", | ||
| } | ||
| ) | ||
| assert gl.users.list(search=second_user.username)[0].id == second_user.id | ||
|
|
@@ -143,9 +143,6 @@ def test_user_email(gl, user): | |
|
|
||
|
|
||
| def test_user_custom_attributes(gl, user): | ||
| attrs = user.customattributes.list() | ||
| assert not attrs | ||
|
|
||
| attr = user.customattributes.set("key", "value1") | ||
| assert user in gl.users.list(custom_attributes={"key": "value1"}) | ||
| assert attr.key == "key" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,7 +103,7 @@ def test_create_user(gitlab_cli, gl): | |
| email = "[email protected]" | ||
| username = "user1" | ||
| name = "User One" | ||
| password = "fakepassword" | ||
| password = "E4596f8be406Bc3a14a4ccdb1df80587#!" | ||
|
|
||
| cmd = [ | ||
| "user", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| GITLAB_IMAGE=gitlab/gitlab-ee | ||
| GITLAB_TAG=15.4.0-ee.0 | ||
| GITLAB_TAG=15.8.1-ee.0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.