Skip to content

some updates for release process, docs, testing#26

Merged
Nikratio merged 6 commits intopython-llfuse:masterfrom
ThomasWaldmann:release-process-updates
Oct 4, 2020
Merged

some updates for release process, docs, testing#26
Nikratio merged 6 commits intopython-llfuse:masterfrom
ThomasWaldmann:release-process-updates

Conversation

@ThomasWaldmann
Copy link
Copy Markdown
Collaborator

No description provided.

there were some incompatible changes in python 3.9,
thus code generated by old cython versions won't compile.
@ThomasWaldmann ThomasWaldmann force-pushed the release-process-updates branch from b9eb282 to 1b296e7 Compare October 4, 2020 12:39
@ThomasWaldmann ThomasWaldmann marked this pull request as draft October 4, 2020 12:52
it still worked for py38, but py39 was broken because they
removed some deprecated stuff still present in the old
cython-generated C code.
also: on differently old linux dists
Note: I used the same python versions as for borgbackup because I run
extensive release testing for these versions (which indirectly tests
llfuse also) plus python 3.9 which should also work after fixing llfuse's
cythonized code for it.

There might be a need to drop 3.4 and 3.5 later again because they
are EOL, but for right now, they're still working and tested.
@ThomasWaldmann ThomasWaldmann force-pushed the release-process-updates branch from f5765ab to 3000f1f Compare October 4, 2020 13:08
@ThomasWaldmann
Copy link
Copy Markdown
Collaborator Author

@Nikratio if you like, please review.

@ThomasWaldmann ThomasWaldmann marked this pull request as ready for review October 4, 2020 13:30
@ThomasWaldmann
Copy link
Copy Markdown
Collaborator Author

After this is merged, even the sdist upload using the old/current method should work, I guess.

@Nikratio Nikratio merged commit afb3fd1 into python-llfuse:master Oct 4, 2020
@Nikratio
Copy link
Copy Markdown
Contributor

Nikratio commented Oct 4, 2020

Yes, upload has worked now. Thanks!

@ThomasWaldmann
Copy link
Copy Markdown
Collaborator Author

@Nikratio thanks, that was quick! :-)

Can you upload the tar.gz and your signature there and publish it? I already updated the git tag to point to the new changeset.

https://github.com/python-llfuse/python-llfuse/releases/tag/untagged-17632ef1a622aad81e61

@ThomasWaldmann ThomasWaldmann deleted the release-process-updates branch October 4, 2020 14:48
@Nikratio
Copy link
Copy Markdown
Contributor

Nikratio commented Oct 4, 2020

Is this still needed? I already re-packaged 1.3.7 as tar.gz and uploaded it.

@ThomasWaldmann
Copy link
Copy Markdown
Collaborator Author

It's just to have it on github. It's nice to have it there also in addition to pypi.

You had uploaded the first try (.tar.bz2) there already, but I deleted it as it was superceded by different code in the newer release.

@Nikratio
Copy link
Copy Markdown
Contributor

Nikratio commented Oct 6, 2020

I have just invited you as a PyPi collaborator. Could you take care of the new release?

Similarly, if you don't get a response from me for merge requests within a few days, please feel free to just merge them.

The key that I've been using is my private key, so I think it's best if you sign the release with yours. If you want, I can provide a signed message somewhere that explains that nothing nefarious is going on.

@ThomasWaldmann
Copy link
Copy Markdown
Collaborator Author

OK, thanks! I'll try to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants