Allow for repeated TREND groups#115
Merged
phobson merged 3 commits intopython-metar:masterfrom Dec 7, 2020
Merged
Conversation
akrherz
reviewed
Oct 5, 2020
44bd901 to
4a7ce4b
Compare
Collaborator
|
rebased hoping to get an updated CI and coverage report.... |
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 4 4
Lines 1049 1049
=======================================
Hits 917 917
Misses 132 132
Continue to review full report at Codecov.
|
akrherz
approved these changes
Dec 7, 2020
phobson
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #114 by allowing multiple TREND groups to occur. Since I am just starting with understanding and parsing METAR, please check, if this is OK.
This change now also allows for multiple NOSIG indicators. Would this be OK, or should there be a dedicated group for this case?