Skip to content

support 1,3,6 hour ice accretion#78

Merged
phobson merged 1 commit intopython-metar:masterfrom
akrherz:issue77
Jan 14, 2019
Merged

support 1,3,6 hour ice accretion#78
phobson merged 1 commit intopython-metar:masterfrom
akrherz:issue77

Conversation

@akrherz
Copy link
Collaborator

@akrherz akrherz commented Jan 14, 2019

closes #77

@akrherz akrherz requested a review from phobson January 14, 2019 20:12
@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #78 into master will increase coverage by 0.65%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   87.32%   87.98%   +0.65%     
==========================================
  Files           4        4              
  Lines        1018     1032      +14     
==========================================
+ Hits          889      908      +19     
+ Misses        129      124       -5
Impacted Files Coverage Δ
metar/Datatypes.py 84.61% <100%> (+0.28%) ⬆️
metar/Metar.py 90.46% <100%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47bde0e...269ae43. Read the comment docs.

@akrherz akrherz added this to the 2.0 milestone Jan 14, 2019
@coveralls
Copy link

coveralls commented Jan 14, 2019

Pull Request Test Coverage Report for Build 86

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 87.984%

Files with Coverage Reduction New Missed Lines %
metar/Metar.py 1 90.46%
Totals Coverage Status
Change from base Build 84: 0.7%
Covered Lines: 908
Relevant Lines: 1032

💛 - Coveralls

@akrherz
Copy link
Collaborator Author

akrherz commented Jan 14, 2019

looking at this data more closely, it appears to follow the same precipitation nomenclature such that 000 represents a TRACE value. Gonna seek some confirmation on this first, so please hold of on merging for the moment.

@akrherz
Copy link
Collaborator Author

akrherz commented Jan 14, 2019

@phobson thanks for the review, PR updated and confirmed that 000 is TRACE, so we should be good to merge now.

@phobson phobson merged commit 464aebb into python-metar:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Ice Group IXnnn

4 participants