east asia, chinese font family#329
Open
leonzhu211 wants to merge 1 commit intopython-openxml:masterfrom
Open
Conversation
fengdasuk19
added a commit
to fengdasuk19/python-docx
that referenced
this pull request
Feb 13, 2020
* Update the unittest for PR [python-openxml#329](python-openxml#329)
|
The unit test code has been updated in PR #781 . |
|
are we ready to merge this (and also #781 )? |
Author
|
The pull request has been rejected by the author of the original project.
…------------------ 原始邮件 ------------------
发件人: "python-openxml/python-docx" ***@***.***>;
发送时间: 2021年10月26日(星期二) 晚上8:36
***@***.***>;
***@***.******@***.***>;
主题: Re: [python-openxml/python-docx] east asia, chinese font family (#329)
are we ready to merge this (and also #781 )?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
Do you know the reasoning? i applied this patch manually and it works.
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: leon zhu ***@***.***>
发送时间: Thursday, October 28, 2021 10:22:16 AM
收件人: python-openxml/python-docx ***@***.***>
抄送: ruixingw ***@***.***>; Comment ***@***.***>
主题: Re: [python-openxml/python-docx] east asia, chinese font family (#329)
The pull request has been rejected by the author of the original project.
------------------ 原始邮件 ------------------
发件人: "python-openxml/python-docx" ***@***.***>;
发送时间: 2021年10月26日(星期二) 晚上8:36
***@***.***>;
***@***.******@***.***>;
主题: Re: [python-openxml/python-docx] east asia, chinese font family (#329)
are we ready to merge this (and also #781 )?
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#329 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADJYPA74CXNKRQHVQMWA4KTUJCXVRANCNFSM4CUDN73A>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Contributor
|
We generally don't accept pull requests. The engineering standard is generally just too high and almost all PRs require more rework than implementing ourselves from scratch. For example, this one includes no analysis documentation, no tests, and the CI tests fail. If you want to merge code, best thing is probably to fork and use a private version. New versions are relatively infrequent and most can be merged or rebased onto without too much trouble. At the same time, we welcome PRs because they often inform features that are later built and can be informative or useful to others who want the same feature and are willing to work from a private fork. |
|
sounds good. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My test code is like this:
styles = document.styles
s1 = styles.add_style('s1', WD_STYLE_TYPE.PARAGRAPH)
s1.font.size = Pt(40)
s1.font.name = u'楷体_GB2312'
document.add_paragraph(u'中文内容', style = s1)
The chinese font family name has no effect.
So I create a docx file with the goal content, unzip it and compare the xml with that generated by python-docx. I find that the difference is the following fragment:
<w:rFonts w:eastAsia="楷体_GB2312" w:asciiTheme="minorAscii" w:hAnsiTheme="minorAscii"/>/w:rPr
That's why I add the property 'eastAsia'.