Open
Conversation
added 2 commits
May 13, 2019 15:41
lordofhyphens
approved these changes
Apr 20, 2021
lordofhyphens
left a comment
There was a problem hiding this comment.
Looks pretty straightforward to me for minimal additional work.
|
Hi. Will this PR not get merged? Thank you. |
Contributor
|
Not in its present state. There is no analysis documentation and no tests. The analysis document would need to account for how macros are stored in the If this solution is good enough for your purposes you can just merge it into a private fork of the latest release and use that private fork. |
goncalor
added a commit
to goncalor/python-docx
that referenced
this pull request
Aug 9, 2021
|
FYI, #716 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I saw few topics about '.docm' (docx with maccro) compatibility files so I decided to create a pull request. I think that could help some peoples.
api.py: modify
if document_part.content_type not in [CT.WML_DOCUMENT_MAIN, CT.WML_DOCUMENT_MACRO_ENABLED_MAIN]:
constants.py: append
WML_DOCUMENT_MACRO_ENABLED_MAIN = ( 'application/vnd.ms-word.document.macroEnabled.main+xml' )
init.py: append
PartFactory.part_type_for[CT.WML_DOCUMENT_MACRO_ENABLED_MAIN] = DocumentPart