Provide api to access footnote, endnote#860
Open
br-rkdrnf wants to merge 1 commit intopython-openxml:masterfrom
Open
Provide api to access footnote, endnote#860br-rkdrnf wants to merge 1 commit intopython-openxml:masterfrom
br-rkdrnf wants to merge 1 commit intopython-openxml:masterfrom
Conversation
This was referenced Sep 4, 2020
|
I really like what you did |
|
@br-rkdrnf Thanks for your great work. I have tried your footnote version, I find that it can access the footnotes which have already existed in the document, but I can't add a new footnote for a run, which is the right behavior or I just miss something from your code? |
|
May i ask how to add footnote in run level? Like run.add_footnote() |
|
Any update on merging this one? |
epicfaace
reviewed
Feb 11, 2023
epicfaace
left a comment
There was a problem hiding this comment.
This is great -- can you also update the docs?
|
I'm expecting this to be released soon in docx |
balmacefa
approved these changes
Jul 6, 2023
deantajohn
approved these changes
Jul 6, 2023
|
Hey, what's the status on this PR? 😀 |
FranciscoPereira9
added a commit
to ml6team/python-docx
that referenced
this pull request
Nov 2, 2023
|
@scanny Any updates on merging footnote support into the library? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to provide API to access and manipulate footnotes and endnotes.
Tests are not implemented yet but if it is determined to be acceptable, I will implement tests for those new APIs.
Mainly, it adds
footnotesandendnotesgetter torunproxy class to provide access to footnotes and endnotes.