Skip to content

Fix iscsi enum use for modern cython #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosjat merged 1 commit into from
Nov 10, 2025
Merged

Fix iscsi enum use for modern cython #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions pyscsi/pyiscsi/iscsi_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,10 @@ def open(self, device):
self._iscsi = iscsi.Context(device)
self._iscsi_url = iscsi.URL(self._iscsi, self._file_name)
self._iscsi.set_targetname(self._iscsi_url.target)
self._iscsi.set_session_type(iscsi.ISCSI_SESSION_NORMAL)
self._iscsi.set_header_digest(iscsi.ISCSI_HEADER_DIGEST_NONE_CRC32C)
self._iscsi.set_session_type(iscsi.iscsi_session_type.ISCSI_SESSION_NORMAL)
self._iscsi.set_header_digest(
iscsi.iscsi_header_digest.ISCSI_HEADER_DIGEST_NONE_CRC32C
)
self._iscsi.connect(self._iscsi_url.portal, self._iscsi_url.lun)

def close(self):
Expand All @@ -86,13 +88,13 @@ def execute(self, cmd, en_raw_sense=False):
execute a scsi command
:param cmd: a scsi command
"""
dir = iscsi.SCSI_XFER_NONE
dir = iscsi.scsi_xfer_dir.SCSI_XFER_NONE
xferlen = 0
if len(cmd.datain):
dir = iscsi.SCSI_XFER_READ
dir = iscsi.scsi_xfer_dir.SCSI_XFER_READ
xferlen = len(cmd.datain)
if len(cmd.dataout):
dir = iscsi.SCSI_XFER_WRITE
dir = iscsi.scsi_xfer_dir.SCSI_XFER_WRITE
xferlen = len(cmd.dataout)
task = iscsi.Task(cmd.cdb, dir, xferlen)
self._iscsi.command(self._iscsi_url.lun, task, cmd.dataout, cmd.datain)
Expand Down