Skip to content

Fix generated code for signals#118

Merged
igo95862 merged 1 commit intopython-sdbus:masterfrom
SqueakyBeaver:master
Apr 11, 2026
Merged

Fix generated code for signals#118
igo95862 merged 1 commit intopython-sdbus:masterfrom
SqueakyBeaver:master

Conversation

@SqueakyBeaver
Copy link
Copy Markdown
Contributor

@SqueakyBeaver SqueakyBeaver commented Apr 11, 2026

When calling python -m sdbus gen-from-file <introspection file>, the generated code would generate signal decorators with the argument signal_name=signal.method_name.

This PR fixes that and the argument is now signal_name="<method_name>"

Before:

@dbus_signal_async(
        signal_signature="si",
        signal_args_names=('cellularNetworkType', 'cellularNetworkStrength'),
        signal_name=signal.method_name, # Incorrect
    )
    def refreshed(self) -> tuple[str, int]:
        raise NotImplementedError

After:

@dbus_signal_async(
        signal_signature="si",
        signal_args_names=('cellularNetworkType', 'cellularNetworkStrength'),
        signal_name="refreshed",
    )
    def refreshed(self) -> tuple[str, int]:
        raise NotImplementedError

@igo95862 igo95862 merged commit f2b4865 into python-sdbus:master Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SqueakyBeaver @igo95862