Open
Conversation
added 2 commits
December 2, 2024 12:06
anjali-deshpande-hub
suggested changes
Dec 11, 2024
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Well done!
Just one thing to change. The PR has changes to assignment_1.ipynb file as well. It should only have changes to assignment_2.ipynb
|
In order to fix the problem of changes in assignment_1.ipynb in assignment_2 branch, follow the steps listed in thread https://uoft-dsi-certificates.slack.com/archives/C07VC7M4PTL/p1733888327768759 |
anjali-deshpande-hub
approved these changes
Dec 14, 2024
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
The problem is fixed now. You can check yourself by going over 'Files Changed' in the PR.
Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
added different operation based on operation argument
What did you learn from the changes you have made?
I learned how to utilize Numpy efficiently!
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
not for this assignment haha
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
no, I think at this stage I was able to gasp the basics of python and its built in function Numpy
How were these changes tested?
shift + enter
A reference to a related issue in your repository (if applicable)
none
Checklist