Conversation
Member
|
@pbrisbin can we fixup the codeclimate issues detected (with the possible exception of the "long method" one... that's more subjective)? |
Contributor
Author
|
Always. |
Contributor
There was a problem hiding this comment.
What's the value of this change?
Contributor
Author
There was a problem hiding this comment.
It was a drive-by fix: args is unused, if this were written today, it would be a rubocop issue.
Ensure consistent expansion of **/*-style globs
- Remove unused EngineProcess autoload - Engine exception non-string json configuration - Handling dev_mode is encapsulated in EngineRegistry - Extracted PathPatterns for reusable globbing logic - Extraced EnginesRunner for reusable engines running logic
Contributor
Author
There was a problem hiding this comment.
I think this should be config.enabled?, it's a true CC::Yaml object now.
This is to ensure no regressions in this area. PathPatterns is coming to become our defacto glob handler and it must be solid.
Contributor
|
LGTM |
gdiggs
added a commit
that referenced
this pull request
Jul 24, 2015
Extract shareable classes, improve interfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @codeclimate/review