Support for unicode characters and a right to left progress bar#86
Merged
gaborcsardi merged 1 commit intor-lib:masterfrom Feb 15, 2019
Merged
Support for unicode characters and a right to left progress bar#86gaborcsardi merged 1 commit intor-lib:masterfrom
gaborcsardi merged 1 commit intor-lib:masterfrom
Conversation
Member
Author
|
I am not entirely sure I will keep this PB in vroom, but I think this could still be useful in general. |
Member
|
Thanks, looks good! |
jimhester
commented
Feb 15, 2019
| double start; // Start time | ||
| bool toupdate; // Are we updating? (After show_after.) | ||
| bool complete; // Are we complete? | ||
| bool reverse; // go from right to left rather than left to right |
Member
Author
There was a problem hiding this comment.
I think I neglected to initialize this in the ctor above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were the changes needed for my extremely important vroom progress bar (https://asciinema.org/a/FSsKkqqxmTQ6vjI8DWy2LqbRp)