Skip to content

make NAPTR discovery tag configurable#103

Open
restena-sw wants to merge 1 commit intoradsecproxy:masterfrom
restena-sw:patch-1
Open

make NAPTR discovery tag configurable#103
restena-sw wants to merge 1 commit intoradsecproxy:masterfrom
restena-sw:patch-1

Conversation

@restena-sw
Copy link
Copy Markdown

still defaults to "x-eduroam:radius.tls" if second optional parameter is omitted
other tags, especially "aaa+auth:radius.tls.tcp" are useful for other roaming consortia (RFC7585-based, OpenRoaming)

still defaults to "x-eduroam:radius.tls" if second optional parameter is omitted
other tags, especially "aaa+auth:radius.tls.tcp" are useful for other roaming consortia (RFC7585-based, OpenRoaming)
@fmauchle
Copy link
Copy Markdown
Contributor

fmauchle commented Jan 8, 2023

I doubt this will work with radsecproxy. The configured script is executed as a file using execlp(), passing exactly one argument, the realm. Did you test it? (if any, the realm argument would always have to be last)

Also note competing PR #105

@restena-sw
Copy link
Copy Markdown
Author

Well, I tested it in FreeRADIUS and had the hope to make the script common across both.

Maybe worth switching from execlp() to another exec() call that supports multiple arguments?

@hgot07
Copy link
Copy Markdown

hgot07 commented Jan 9, 2023

I like the idea of making the NAPTR discovery tag configurable from the radsecproxy.conf file. If this modification is to be merged, it would help OpenRoaming implementers even without my #105.

@fmauchle
Copy link
Copy Markdown
Contributor

Note that the next release is planned to get native dynamic discovery (with configurable NAPTR or SRV record), without external scripts.

@hgot07
Copy link
Copy Markdown

hgot07 commented Jan 16, 2023

That sounds good for performance.
Besides, I'd like to ask you to leave the current external script calling mechanism as an option. Some use cases may require complex realm handling. For example, 3GPP adoption in OpenRoaming requires stream-editing the realm and a couple of naptr lookup trials.

@fmauchle
Copy link
Copy Markdown
Contributor

yes, the existing script mechanism will be kept as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants