Fix gradio passing overrides to tts.py#13
Merged
randombk merged 1 commit intorandombk:masterfrom Aug 30, 2025
Merged
Conversation
* Add diffusion steps to gradio with default 10
3602e5d to
63a451c
Compare
|
Thanks, this is great! |
Owner
|
LGTM, and thanks for the feedback on the step count - I'll change it back to the default 10. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@randombk This vLLM version is incredible! I'm getting like 16-18x speedup in batch mode! Thank you so much for making it! I have no idea how you did it, but it's amazing!
I found the audio quality of the vLLM to be appreciably worse than the original and went hunting for the reason. I saw the diffusion steps were set down and set them up and that fixed it! So I'd recommend defaulting to 10. vLLM is still loads faster than the original with 10 steps, so I think letting people manually set down the quality for even more speed is better.
Also fixes errors like