Fix: Early file downloading w/ custom onClick function#201
Open
eliasthompson wants to merge 1 commit intoreact-csv:masterfrom
Open
Fix: Early file downloading w/ custom onClick function#201eliasthompson wants to merge 1 commit intoreact-csv:masterfrom
eliasthompson wants to merge 1 commit intoreact-csv:masterfrom
Conversation
…e download doesn't trigger too early (noticable on async onClicks)
crivera
reviewed
Mar 19, 2020
| return this.props.asyncOnClick | ||
| ? this.handleAsyncClick(event) | ||
| : this.handleSyncClick(event); | ||
| } else { |
There was a problem hiding this comment.
why would this change anything? it doesn't get called since the previous line has a return?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should address #99 and #189.