Merged
Conversation
Fixes BITFIELD's syntax Improves readability of SET Fixes GEOSEARCH and GEOSEARCH_RO syntices Fixes MIGRATE syntax Fixes MODULE LOADEX syntax
oranagra
reviewed
Apr 5, 2022
oranagra
approved these changes
Apr 6, 2022
| "2.6.0" }, | ||
| { "BITFIELD", | ||
| "key [GET encoding offset] [SET encoding offset value] [INCRBY encoding offset increment] [OVERFLOW WRAP|SAT|FAIL]", | ||
| "key GET encoding offset|[OVERFLOW WRAP|SAT|FAIL] SET encoding offset value|INCRBY encoding offset increment [GET encoding offset|[OVERFLOW WRAP|SAT|FAIL] SET encoding offset value|INCRBY encoding offset increment ...]", |
Member
There was a problem hiding this comment.
looks like some parenthesis are needed, but that's out of the scope of this PR.
i suppose any element in a oneof or block with more than one element in it, should add (), but then we'll need redis-cli to handle that.
@jhelbaum FYI.
Contributor
There was a problem hiding this comment.
If we decide to modify the syntax in general, we need to sync that with redis.io too.
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
Fixes in command argument in json files
* Fixes BITFIELD's syntax ("sub-commands" can be repeated, and OVERFLOW is only valid for SET and INCR)
* Improves readability of SET (reordered)
* Fixes GEOSEARCH and GEOSEARCH_RO syntices (use `oneof` for mutually exclusive group instead of `optional`)
* Fixes MIGRATE syntax (use `oneof` for mutually exclusive group instead of `optional`)
* Fixes MODULE LOADEX syntax (the `CONFIG` token should be repeated too when using multiple configs)
other:
* make generate-command-help.rb accept a path to commands.json, or read it from stdin (e.g. `generate-commands-json.py | generate-command-help.rb -`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes in command argument in json files
oneoffor mutually exclusive group instead ofoptional)oneoffor mutually exclusive group instead ofoptional)CONFIGtoken should be repeated too when using multiple configs)other:
generate-commands-json.py | generate-command-help.rb -)