Skip to content

COMMAND DOCS shows module name, where applicable#10544

Merged
oranagra merged 2 commits intoredis:unstablefrom
guybe7:command_docs_module
Apr 10, 2022
Merged

COMMAND DOCS shows module name, where applicable#10544
oranagra merged 2 commits intoredis:unstablefrom
guybe7:command_docs_module

Conversation

@guybe7
Copy link
Copy Markdown
Collaborator

@guybe7 guybe7 commented Apr 6, 2022

Add field to COMMAND DOCS response to denote the name of the module that added that command.
COMMAND LIST can filter by module, but if you get the full commands list, you may still wanna know which command belongs to which module.
The alternative would be to do MODULE LIST, and then multiple calls to COMMAND LIST

Fix #10416

Comment thread src/module.c Outdated
Copy link
Copy Markdown
Member

@oranagra oranagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redis/core-team please approve.
i.e. COMMAND LIST can filter by module, but if you get the full commands list, you may still wanna know which command belongs to which module.
the alternative would be to do MODULE LIST, and then multiple calls to COMMAND LIST (i guess that's not that bad)

@oranagra oranagra added state:major-decision Requires core team consensus approval-needed Waiting for core team approval to be merged labels Apr 6, 2022
@oranagra oranagra added the release-notes indication that this issue needs to be mentioned in the release notes label Apr 7, 2022
@bashanyy
Copy link
Copy Markdown

bashanyy commented Apr 10, 2022 via email

@oranagra oranagra merged commit 719db14 into redis:unstable Apr 10, 2022
@oranagra
Copy link
Copy Markdown
Member

@guybe7 please make a redis-doc PR and ping me.

@oranagra oranagra mentioned this pull request Apr 27, 2022
enjoy-binbin pushed a commit to enjoy-binbin/redis that referenced this pull request Jul 31, 2023
Add field to COMMAND DOCS response to denote the name of the module
that added that command.
COMMAND LIST can filter by module, but if you get the full commands list,
you may still wanna know which command belongs to which module.
The alternative would be to do MODULE LIST, and then multiple calls to COMMAND LIST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval-needed Waiting for core team approval to be merged release-notes indication that this issue needs to be mentioned in the release notes state:major-decision Requires core team consensus

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[NEW] COMMAND DOCS should also return the module's name (when applicable)

8 participants