Add module API flag for using enum configs as bit flags#10643
Merged
oranagra merged 2 commits intoredis:unstablefrom Apr 26, 2022
oranagra:module_enum_flags
Merged
Add module API flag for using enum configs as bit flags#10643oranagra merged 2 commits intoredis:unstablefrom oranagra:module_enum_flags
oranagra merged 2 commits intoredis:unstablefrom
oranagra:module_enum_flags
Conversation
yossigo
approved these changes
Apr 26, 2022
madolson
approved these changes
Apr 26, 2022
madolson
reviewed
Apr 26, 2022
Co-authored-by: Madelyn Olson <[email protected]>
This was referenced Apr 27, 2022
Merged
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
Enables registration of an enum config that'll let the user pass multiple keywords that
will be combined with `|` as flags into the integer config value.
```
const char *enum_vals[] = {"none", "one", "two", "three"};
const int int_vals[] = {0, 1, 2, 4};
if (RedisModule_RegisterEnumConfig(ctx, "flags", 3, REDISMODULE_CONFIG_DEFAULT | REDISMODULE_CONFIG_BITFLAGS, enum_vals, int_vals, 4, getFlagsConfigCommand, setFlagsConfigCommand, NULL, NULL) == REDISMODULE_ERR) {
return REDISMODULE_ERR;
}
```
doing:
`config set moduleconfigs.flags "two three"` will result in 6 being passed to`setFlagsConfigCommand`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables registration of an enum config that'll let the user pass multiple keywords that will be combined with
|as flags into the integer config value.doing:
config set moduleconfigs.flags "two three"will result in 6 being passed tosetFlagsConfigCommand.