Skip to content

Object/obj resource creation duplication issue #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ConnorMac wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Object/obj resource creation duplication issue #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions rehive/api/resources/base_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,20 +264,32 @@ def __init__(self):

def create_resources(self, resources):
for resource in resources:
setattr(self,
if not hasattr(self, self._sanitize_resource_name(resource.get_resource_name())):
setattr(
self,
self._sanitize_resource_name(
resource.get_resource_name()),
resource(self.client, self.endpoint))
resource.get_resource_name()
),
resource(self.client, self.endpoint)
)

def obj(self, resource_identifiter):
return self.object(resource_identifiter)

def object(self, resource_identifiter):
resource_object = copy.copy(self)
resource_object._set_resource_identifier(resource_identifiter)
resource_object._set_endpoint(resource_object.endpoint + resource_object.resource_identifier)
resource_object.create_resources(resource_object.resources)
return resource_object
"""
Function takes in a resource and an identifier and turns the .obj instance into a reference
of the current Resource class

Example: admin.groups.object('user') -> AdminGroups() class instance with the 'user' identifier attached

It also appends any sub resources to the class such as AdminPermissions etc
"""
self._set_resource_identifier(resource_identifiter)
# if not self.endpoint.contains(self.resource_identifier):
self._set_endpoint(self.endpoint + self.resource_identifier)
self.create_resources(self.resources)
return self

def _sanitize_resource_name(self, string):
return string.replace('-', '_')