Merged
Conversation
Member
tok-kkk
commented
Nov 8, 2021
- Add support for apple silicon (M1 chip)
- fix installation script not setting the $PATH in some cases
- fix gcp template syntax error
- move from circleCI to github action
- github client rate limiting
improve deployment logic remove unessasary error checking fix gcp template syntax fix version variable name using zprofile fix export in release verification revert contract bindings
rahulghangas
suggested changes
Nov 10, 2021
rahulghangas
left a comment
There was a problem hiding this comment.
Did an initial pass, didn't find any major issues. How can I test this locally?
jazg
approved these changes
Nov 15, 2021
Member
|
Approved as @tok-kkk has resolved the comments from the initial review, and it has been confirmed to be working after testing locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.