Remove --x-localimage experimental feature#2670
Merged
markphelps merged 1 commit intomainfrom Feb 2, 2026
Merged
Conversation
Remove the --x-localimage flag and all associated code that was never shipped. This includes: - CLI flag from build, push, predict, run, debug, and serve commands - LocalImage field from BuildOptions and log contexts - localImage parameter from dockerfile generators - FillInWeightsManifestVolumes and WeightManifest (dead code) - CogWeightsManifestLabelKey label constant - Integration tests for the feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
--x-localimageexperimental flag and all associated code that was never shipped.--x-localimagewas an experimental flag that attempted to speed up local development by mounting weights as runtime volumes and rsyncing source files instead of copying them into the image.Changes
--x-localimageCLI flag from build, push, predict, run, debug, and serve commandsLocalImagefield fromBuildOptionsand log contextslocalImageparameter from dockerfile generatorsFillInWeightsManifestVolumesfunction andWeightManifesttype (dead code only used by this feature)CogWeightsManifestLabelKeylabel constantTesting