Merged
Conversation
Pipelines was an experimental feature that will not launch. This removes all pipeline-related code to simplify the codebase ahead of upcoming major changes. Removed: - pkg/api/ - Pipeline API client (PostNewPipeline, PullSource) - pkg/procedure/ - Pipeline validation logic - pkg/docker/pipeline_push.go - Pipeline push implementation - pkg/cli/pull.go - Pipeline-only pull command - pkg/image/model_dependencies.go - Pipeline dependency analysis (replicate.use) - pkg/coglog/pull_log_context.go - Orphaned pull logging - pkg/cli/init-templates/pipeline/ - Pipeline init templates - python/cog/command/call_graph.py - Python call graph analysis - Integration tests for pipelines Also removed: - --x-pipeline hidden flag from build, push, predict, run, init commands - PipelinesImage field from BuildOptions - Pipeline field from docker.BuildInfo - R8_PIPELINES_RUNTIME_HOST environment variable - run.cog.r8_model_dependencies image label
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the experimental pipelines feature that will not launch, simplifying the codebase ahead of upcoming major changes.
Removed (~3,650 lines)
Go packages:
pkg/api/- Pipeline API client (PostNewPipeline, PullSource)pkg/procedure/- Pipeline validation logicGo files:
pkg/docker/pipeline_push.go- Pipeline push implementationpkg/cli/pull.go- Pipeline-only pull commandpkg/image/model_dependencies.go- Pipeline dependency analysispkg/coglog/pull_log_context.go- Orphaned pull loggingTemplates & Python:
pkg/cli/init-templates/pipeline/- Pipeline init templatespython/cog/command/call_graph.py- Python call graph analysisCLI changes:
--x-pipelinehidden flag from build, push, predict, run, initcog pullcommandOther removals:
PipelinesImagefield from BuildOptionsPipelinefield from docker.BuildInfoR8_PIPELINES_RUNTIME_HOSTenvironment variablerun.cog.r8_model_dependenciesimage labelTesting