Remove integration-tests/go.mod, consolidate into root module#2708
Merged
tempusfrangit merged 5 commits intomainfrom Feb 10, 2026
Merged
Remove integration-tests/go.mod, consolidate into root module#2708tempusfrangit merged 5 commits intomainfrom
tempusfrangit merged 5 commits intomainfrom
Conversation
98ad0de to
0928894
Compare
Maintaining two nested go.mod/go.sum files required manual sync of transitive dependencies. Merge the integration-tests module into the root module to eliminate this pain. - Delete integration-tests/go.mod and go.sum - Promote 4 deps from indirect to direct in root go.mod - Update mise.toml and CI to use ./integration-tests/... package path - Fix stale comments referencing the old separate module
0928894 to
29518d9
Compare
Signed-off-by: Morgan Fainberg <[email protected]>
tempusfrangit
previously approved these changes
Feb 10, 2026
The integration test harness was calling 'make wheel' which only builds the SDK wheel (cog-*.whl) via 'mise run build:sdk', but it checks for both SDK and coglet wheels. This caused build failures in CI. Changed to use 'mise run build:wheels' which builds both cog and coglet wheels, matching what the harness actually checks for.
tempusfrangit
previously approved these changes
Feb 10, 2026
After consolidating integration-tests into the root Go module, the grep -v /integration-tests/ filter in test:go missed the root package (no trailing slash), causing TestIntegration to run in the unit test job without mise, COG_BINARY, or Docker. Replace the fragile grep filter with a //go:build integration constraint on suite_test.go. Unit test jobs now use plain ./... and integration test jobs pass -tags integration.
Tag login_test.go and concurrent_test.go with //go:build integration to match suite_test.go. Without this, these tests still compiled in the unit test job and failed looking for mise.
tempusfrangit
approved these changes
Feb 10, 2026
Contributor
|
@markphelps this needs a reviewer not named Michael Dwan or Morgan Fainberg. When you have a chance, would be appreciated. |
markphelps
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integration-tests/go.modandgo.sum, merging the integration tests into the root Go modulego.modfilesreplace github.com/replicate/cog => ../directive that was a source of frictionChanges
integration-tests/go.modandintegration-tests/go.sum: Deletedgo.mod: 4 deps promoted from indirect to direct (creack/pty,rogpeppe/go-internal,containerd/errdefs,moby/docker-image-spec)mise.toml: Removeddir = "integration-tests"from test tasks, added./integration-tests/...package path to gotestsum commands.github/workflows/ci.yaml: Removedintegration-tests/go.sumfrom Go cache path, removedworking-directory, added./integration-tests/...to gotestsumintegration-tests/harness/harness.go: Fixed 2 stale comments that referenced the old separate moduleVerification
go vet ./...passesgo mod tidyis clean (no drift)go build -tags integration ./integration-tests/...succeedsIntegration tests are behind the
integrationbuild flag. Both CI and MISE have been updated to use the tag.