Remove orphaned tests property from cog.yaml schema#2809
Merged
michaeldwan merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
The tests config option was removed from the Go implementation in PR #2181 but its JSON schema definition was left behind. Remove the orphaned schema property to avoid confusion.
michaeldwan
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testsproperty from thecog.yamlJSON schema (pkg/config/data/config_schema_v1.0.json)testsconfig option was added in PR Require a test to be added for fast push #2149 and the Go implementation was removed in PR Move fast push test to cog-runtime #2181, but the schema definition was left behindConfigstruct already ignores the field, but cleaning it up avoids confusion