Skip to content

Ability to load config module through data-config attribute#763

Closed
tleite wants to merge 1 commit intorequirejs:masterfrom
tleite:master
Closed

Ability to load config module through data-config attribute#763
tleite wants to merge 1 commit intorequirejs:masterfrom
tleite:master

Conversation

@tleite
Copy link
Copy Markdown

@tleite tleite commented Jun 6, 2013

When using requirejs with multiple pages, it is often helpful to place the requirejs.config paths and shims in a separate module in order to be share amongst all the pages.

This is what I have been doing so far:

<script src="require.js"></script>

<script>
  require(["config"], function() {
    require(["main"], function() {
    })
  });
</script>

After doing it this way for a while, I thought it would be cleaner to do it this way instead:

<script data-config="config-module" data-main="main-module" src="require.js"></script>

I didn't spend much time on this yet, I basically duplicated the section in the code that handles the data-main attribute and renamed the attributes to data-config.

@jrburke
Copy link
Copy Markdown
Member

jrburke commented Jun 10, 2013

Thanks for taking the time to do a pull request. However, there are no plans to add this as it can be done just by inlining the calls:

<script src="require.js"></script>
<script>
require(['config'], function () { require(['main']) });
</script>

I need to balance the size of require.js with features. The above snippet is smaller than the diff needed to implement this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants