Ability to load config module through data-config attribute#763
Closed
tleite wants to merge 1 commit intorequirejs:masterfrom
Closed
Ability to load config module through data-config attribute#763tleite wants to merge 1 commit intorequirejs:masterfrom
tleite wants to merge 1 commit intorequirejs:masterfrom
Conversation
Member
|
Thanks for taking the time to do a pull request. However, there are no plans to add this as it can be done just by inlining the calls: <script src="require.js"></script>
<script>
require(['config'], function () { require(['main']) });
</script>I need to balance the size of require.js with features. The above snippet is smaller than the diff needed to implement this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using requirejs with multiple pages, it is often helpful to place the requirejs.config paths and shims in a separate module in order to be share amongst all the pages.
This is what I have been doing so far:
After doing it this way for a while, I thought it would be cleaner to do it this way instead:
I didn't spend much time on this yet, I basically duplicated the section in the code that handles the data-main attribute and renamed the attributes to data-config.