This repository was archived by the owner on Aug 10, 2020. It is now read-only.
Open
Conversation
Member
|
@Risto-Stevcev would you take it over to move it to https://github.com/reasonml-community/ ? |
Author
|
@bobzhang Sure, I'm not sure how to take it over and move it there though. I'm not a member |
Contributor
|
@Risto-Stevcev I've created https://github.com/reasonml-community/bs-mocha and made you an admin on it. Let me know if you need help moving the code there. @bobzhang Can you give Risto publishing rights for bs-mocha on npm? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated bs-mocha
[@bs]annotations, they seemed to be unnecessary since the bindings worked fine without it (I thinkunit -> unitworks the same curried/uncurried because it's unary)@bobzhang One other thing that I had to do in order to use these bindings is to copy the
bsconfig.jsonfrom thebucklescript-addons/bindings/bs-mochafolder to my project'snode_modules/bs-mochafolder. For some reason all files are there when I install bs-mocha (usingnpm install bs-mocha) except forbsconfig.json, sobsbnever found it. I don't know what's hiding it, I think this is the only thing left to do