MANIFEST.in: Include LICENSE and tests in sdist#141
Merged
gabor-boros merged 1 commit intorethinkdb:masterfrom Sep 13, 2019
Merged
MANIFEST.in: Include LICENSE and tests in sdist#141gabor-boros merged 1 commit intorethinkdb:masterfrom
gabor-boros merged 1 commit intorethinkdb:masterfrom
Conversation
Member
|
@jayvdb why did you commented out the version import and assignment? |
Member
|
Also, thank you a lot for the manifest file! 🎉 |
Contributor
Author
|
Sorry that wasnt intended to be in the patch. (I did it to get past the import of the library, which hasnt been installed yet, and its dependencies are not installed yet, so import fails; another set of packaging bugs) |
gabor-boros
approved these changes
Sep 13, 2019
Member
|
@jayvdb Thank you for fixing this. 🎉🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for the change
Packaging requires a LICENSE file, and benefits greatly from
having test infrastructure to validate the built library.
Description
Created a MANIFEST.in to include LICENSE and tests in the sdist
uploaded to PyPi.
Code examples
Checklist
References