Closed
Conversation
| pass | ||
|
|
||
| class Response: | ||
| class ResponseType: |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| COMPILE_ERROR = 17 | ||
| RUNTIME_ERROR = 18 | ||
|
|
||
| class ErrorType: |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 041dc5d and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
… literal. Did you mean "!="?
Author
|
Apologize for closing/opening. Confirming my verison is working in my 3.11 appliction. Happy to help cherry pick these changes into mainline, but definitely think updates are necessary for continued python support. Love this project, show must go on! |
1 task
Contributor
|
Closing as it has been integrated from another PR #298 @stephanelsmith thanks for the support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for the change
Python3.11 compatibility issues with running
Description
"@asyncio.coroutine" and "yield from" syntax no longer allowed in 3.11. Changed to "async" and "await" respectively.
Code examples
For example, changes made like this:
Checklist
References
I have a number of compatibility updates, made some for 3.10 as well last year. I wanted decreased verbosity in the export.
Happy to cherry pick what makes sense, but would like to see continued support track with Python versions.