Skip to content

bug: fix query representation to string#290

Merged
lsabi merged 1 commit intorethinkdb:masterfrom
liranbg:fix-strinfigying-rql-query
Apr 27, 2023
Merged

bug: fix query representation to string#290
lsabi merged 1 commit intorethinkdb:masterfrom
liranbg:fix-strinfigying-rql-query

Conversation

@liranbg
Copy link
Copy Markdown
Contributor

@liranbg liranbg commented Apr 27, 2023

Reason for the change
If applicable, link the related issue/bug report or write down in few sentences the motivation.

Trying to build a query dynamically and log it

Description
Seems like there was a mass change from st to statement during rethinkdb 2.1->2.4 but that specifically property was not converted right, thus, left the changed line defunc.

This PR changes it back to st until maintainer finishes the refactor

Code examples

from rethinkdb import r
filtering_query_b = (r.row["something"] == "someone") & (r.row["else"] == "else")
print(str(filtering_query_b))

will yield an error of

Unable to serialize object: 'And' object has no attribute 'statement_infix'

Checklist

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 99c521d and detected 0 issues on this pull request.

View more on Code Climate.

@lsabi lsabi merged commit c4e4ef6 into rethinkdb:master Apr 27, 2023
@lsabi
Copy link
Copy Markdown
Contributor

lsabi commented Apr 27, 2023

Thanks for the contribution!

@liranbg liranbg deleted the fix-strinfigying-rql-query branch April 27, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants