Code Climate has analyzed commit 216200d and detected 0 issues on this pull request.

View more on Code Climate.

Why have this change?

The changes are for python 3.5. Furthermore, maintaining python 2.x support while supporting python 3.5 and 3.10+ is complicated.

Do you think python 2.x should still be supported?

Well, right now, the master branch works with Python 2.7. So I don't think we should change the setup.py to disallow Python 2.7.

Also, Python 3.4 should still work, except for asyncio.

As for the future -- your lsabi/commands branch obviously has static types, which would make it impossibly annoying to keep Python 2 support. And such users could simply not upgrade, or use a fork if necessary.

Then it should be changed only to python 2.7 and >=3.5 ?

For the future, I would drop even python <3.6 support, as this has been as noted on the official website https://devguide.python.org/versions/

I don't know enough about Python packaging to know whether adding !=3.4.* is a good idea or not; obviously asyncio stopped working so maybe we want it; I personally would pick whatever is least annoying to users in general but I'm not in charge of this project...

Neither am I in charge, but I believe that most of the users will use python 3.6 or above, since major cloud providers have already dropped support (see list below). The best is to support the currently supported version and optionally 1-2 versions back.

https://aws.amazon.com/blogs/developer/python-support-policy-updates-for-aws-sdks-and-tools/
https://azure.microsoft.com/en-us/updates/azure-functions-support-for-python-36-is-ending-on-30-september-2022/