Conversation
jiggag
reviewed
Dec 23, 2022
Comment on lines
+111
to
+113
| open private(set) var nativeSelector: Selector | ||
| open fileprivate(set) var isExtendJsSelector: Bool // If true, use ObjC style naming. | ||
| open fileprivate(set) var isReturnRequired: Bool |
There was a problem hiding this comment.
이 3가지 프로퍼티는 내부 private이라면 open이 꼭 있어야하나요???
Collaborator
Author
There was a problem hiding this comment.
open은 getter에 대한 접근자인데 jsSelector 말고도 다른 프로퍼티를 외부에서 활용할 수 있도록 고려했어요.
jiggag
approved these changes
Dec 23, 2022
DavinAhn
added a commit
that referenced
this pull request
Jan 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용