Sourcery Starbot ⭐ refactored rohitkumar93/full-stack-fastapi-postgresql#1
Open
SourceryAI wants to merge 1 commit intorohitkumar93:masterfrom
Open
Sourcery Starbot ⭐ refactored rohitkumar93/full-stack-fastapi-postgresql#1SourceryAI wants to merge 1 commit intorohitkumar93:masterfrom
SourceryAI wants to merge 1 commit intorohitkumar93:masterfrom
Conversation
SourceryAI
commented
Feb 14, 2023
Comment on lines
-39
to
+41
| with open(Path(settings.EMAIL_TEMPLATES_DIR) / "test_email.html") as f: | ||
| template_str = f.read() | ||
| template_str = Path( | ||
| Path(settings.EMAIL_TEMPLATES_DIR) / "test_email.html" | ||
| ).read_text() |
Author
There was a problem hiding this comment.
Function send_test_email refactored with the following changes:
- Simplify basic file reads with
pathlib(path-read)
Comment on lines
-52
to
+55
| with open(Path(settings.EMAIL_TEMPLATES_DIR) / "reset_password.html") as f: | ||
| template_str = f.read() | ||
| template_str = Path( | ||
| Path(settings.EMAIL_TEMPLATES_DIR) / "reset_password.html" | ||
| ).read_text() |
Author
There was a problem hiding this comment.
Function send_reset_password_email refactored with the following changes:
- Simplify basic file reads with
pathlib(path-read)
Comment on lines
-73
to
+77
| with open(Path(settings.EMAIL_TEMPLATES_DIR) / "new_account.html") as f: | ||
| template_str = f.read() | ||
| template_str = Path( | ||
| Path(settings.EMAIL_TEMPLATES_DIR) / "new_account.html" | ||
| ).read_text() |
Author
There was a problem hiding this comment.
Function send_new_account_email refactored with the following changes:
- Simplify basic file reads with
pathlib(path-read)
Comment on lines
-95
to
-98
| encoded_jwt = jwt.encode( | ||
| {"exp": exp, "nbf": now, "sub": email}, settings.SECRET_KEY, algorithm="HS256", | ||
| return jwt.encode( | ||
| {"exp": exp, "nbf": now, "sub": email}, | ||
| settings.SECRET_KEY, | ||
| algorithm="HS256", | ||
| ) | ||
| return encoded_jwt |
Author
There was a problem hiding this comment.
Function generate_password_reset_token refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-40
to
-43
| user = crud.user.get(db, id=token_data.sub) | ||
| if not user: | ||
| if user := crud.user.get(db, id=token_data.sub): | ||
| return user | ||
| else: | ||
| raise HTTPException(status_code=404, detail="User not found") | ||
| return user |
Author
There was a problem hiding this comment.
Function get_current_user refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches)
| to_encode = {"exp": expire, "sub": str(subject)} | ||
| encoded_jwt = jwt.encode(to_encode, settings.SECRET_KEY, algorithm=ALGORITHM) | ||
| return encoded_jwt | ||
| return jwt.encode(to_encode, settings.SECRET_KEY, algorithm=ALGORITHM) |
Author
There was a problem hiding this comment.
Function create_access_token refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-41
to
-46
| user = self.get_by_email(db, email=email) | ||
| if not user: | ||
| return None | ||
| if not verify_password(password, user.hashed_password): | ||
| if user := self.get_by_email(db, email=email): | ||
| return user if verify_password(password, user.hashed_password) else None | ||
| else: | ||
| return None | ||
| return user |
Author
There was a problem hiding this comment.
Function CRUDUser.authenticate refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow [×2] (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
| auth_token = response["access_token"] | ||
| headers = {"Authorization": f"Bearer {auth_token}"} | ||
| return headers | ||
| return {"Authorization": f"Bearer {auth_token}"} |
Author
There was a problem hiding this comment.
Function user_authentication_headers refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-42
to
+47
| user = crud.user.get_by_email(db, email=email) | ||
| if not user: | ||
| user_in_create = UserCreate(username=email, email=email, password=password) | ||
| user = crud.user.create(db, obj_in=user_in_create) | ||
| else: | ||
| if user := crud.user.get_by_email(db, email=email): | ||
| user_in_update = UserUpdate(password=password) | ||
| user = crud.user.update(db, db_obj=user, obj_in=user_in_update) | ||
|
|
||
| else: | ||
| user_in_create = UserCreate(username=email, email=email, password=password) | ||
| user = crud.user.create(db, obj_in=user_in_create) |
Author
There was a problem hiding this comment.
Function authentication_token_from_email refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Swap if/else branches (
swap-if-else-branches)
| a_token = tokens["access_token"] | ||
| headers = {"Authorization": f"Bearer {a_token}"} | ||
| return headers | ||
| return {"Authorization": f"Bearer {a_token}"} |
Author
There was a problem hiding this comment.
Function get_superuser_token_headers refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: