Support UTF-8 encoding for non-ASCII QR data (e.g. Korean, emoji)#284
Merged
rosskhanas merged 2 commits intorosskhanas:masterfrom Sep 4, 2025
Merged
Support UTF-8 encoding for non-ASCII QR data (e.g. Korean, emoji)#284rosskhanas merged 2 commits intorosskhanas:masterfrom
rosskhanas merged 2 commits intorosskhanas:masterfrom
Conversation
rosskhanas
requested changes
Sep 3, 2025
| @@ -0,0 +1,33 @@ | |||
| export function encodeStringToUtf8Bytes(input) { | |||
| if (typeof input !== "string") return []; | |||
Owner
There was a problem hiding this comment.
I think this check makes no sense, as it takes value from react component and it is a required prop.
| /> | ||
| ); | ||
| }); | ||
| export const QRCode = forwardRef( |
Owner
There was a problem hiding this comment.
There is biome config with 140 chars in 1 line, I think you have some smaller value in your config, ideally not to change all this haha
Owner
|
감사합니다, @GraceKim527 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#283
✨ Improvement Suggestion
🔁 Refactor