This repository was archived by the owner on Sep 16, 2020. It is now read-only.
Merged
Conversation
Still to do: Read credentials from the .env Make the csrf cookie work in the tests!
Removes setup and use of nginx and uwsgi.
Collaborator
Author
|
Still TODO: make the left and right sensors get their pin numbers from the online config. We're already getting that information back when we register/check-in, so it won't be a problem at all! |
cabarnes
suggested changes
Jun 28, 2017
Member
cabarnes
left a comment
There was a problem hiding this comment.
There are also some wsgi references in setup.sh, .coveragerc, and .prospector.yaml that you might want to remove as well.
Dockerfile
Outdated
|
|
||
| WORKDIR /var/www/rovercode/www/Adafruit_Python_GPIO | ||
| RUN python setup.py install | ||
| WORKDIR /var/www/rovercode |
Member
There was a problem hiding this comment.
You shouldn't need this since the next line changes the WORKDIR again
www/app.py
Outdated
| @@ -99,56 +79,91 @@ class HeartBeatManager(): | |||
| The json-formatted information about the rover to send to rovercode-web. | |||
Member
There was a problem hiding this comment.
The param documentation needs to be updated for the new constructor parameters.
Collaborator
Author
|
Sorry, sneaking in one more feature to this PR. Now the gpio input inits get their pins from the data returned from rovercode-web. |
cabarnes
approved these changes
Jun 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a rover use user credentials to register itself with rovercode web. This matches the change to rovercode-web: rovercode/rovercode-web#74
I also took the opportunity to restructure app.py to have a
__main__. This is important, because previously the tests were triggering real network calls.While restructuring, I decided that there's no real need for nginx and uwsgi anymore, since we are not serving mission-control from the rover. Instead, we'll just serve the API using flask-socketio wrapping eventlet.