Merged
Conversation
hbradio
commented
Aug 8, 2019
realtime/consumers.py
Outdated
| return | ||
|
|
||
| if rover.owner.id != user.id: | ||
| shared_user_ids = [user.id for user in rover.shared_users.all()] |
Collaborator
Author
There was a problem hiding this comment.
I don't practice much with the Django ORM. Is there a better way to do this?
Member
There was a problem hiding this comment.
You could do something like:
is_shared_user = rover.shared_users.filter(id=user.id).exists()
cabarnes
reviewed
Aug 8, 2019
realtime/consumers.py
Outdated
| return | ||
|
|
||
| if rover.owner.id != user.id: | ||
| shared_user_ids = [user.id for user in rover.shared_users.all()] |
Member
There was a problem hiding this comment.
You could do something like:
is_shared_user = rover.shared_users.filter(id=user.id).exists()
| local_ip='8.8.8.8', | ||
| oauth_application=oauth_app, | ||
| ) | ||
| rover.shared_users.set([shared_user]) |
Member
There was a problem hiding this comment.
This can be .add if you don't want to have to make it a list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the websocket security check allow shared users. I realized I forgotten about this in the last shared-users PR.