Merged
Conversation
…of with the rover
Collaborator
Author
|
Whoops. Forgot to run the linter. Will fix in a bit. |
…rcode-web into feature/Load_bds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we load block diagrams from the rovercode.com interface instead of from the rover's interface.
Also, made it pull in the base xml for all new block diagrams ('event_handler_hidden'). Simplest solution I could think of was just to search for it by name amongst the other block diagrams. I'm open to other ideas.
This made me realize that we should probably secure block diagrams by owner in the future. Right now, only one's own block diagrams are presented in mission-control, but others' could be loaded and edited via the console.
This hasn't added the feature of launching mission control immediately into a saved block diagram. I'll work on that in a separate PR.