Bugfix: memory leaks are prevented#18
Merged
rscada merged 4 commits intorscada:masterfrom Sep 17, 2016
Merged
Conversation
[NCB-239] MBus wrapper frees malloc'd memory
[NCB-239] Fixed example to prevent memory leak
Contributor
Author
|
As a separate note, we're wondering if you'd be interested in sharing this package through PyPI. |
Owner
|
Thanks for the fixes! Also, having this package on PyPI is fine with me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the development of a long-running service based on python-mbus, we realized that the library was leaking. This was traced to three issues:
This pull request addresses all three issues and corrects the example accordingly.
If you have any comment or remark, we'll be happy to address those as part of this PR.
Thank you.