Ensure DeafultPayload#create methods copy ByteBuf content#993
Merged
rstoyanchev merged 1 commit intorsocket:1.0.xfrom Mar 3, 2021
Merged
Ensure DeafultPayload#create methods copy ByteBuf content#993rstoyanchev merged 1 commit intorsocket:1.0.xfrom
rstoyanchev merged 1 commit intorsocket:1.0.xfrom
Conversation
b2515e9 to
80c5b7e
Compare
80c5b7e to
2e04ccb
Compare
Closes rsocketgh-970 Signed-off-by: Rossen Stoyanchev <[email protected]>
2e04ccb to
e06ee7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RSocketConnector method that takes a setupPayload as
Payload, as documented, tries to make a copy of aByteBufPayloadin order to ensure it can be re-used (e.g. on reconnect). However,DefaultPayload#createwasn't really making a copy. This PR fixes that and ensures thatDefaultPayloadcopies data and metadata from ByteBuf's.This is likely a fix for #970.